[MUST BE CAREFULLY REVIEWED] saltcloud / lxc improvments #10869

kiorky · 2014-02-28T19:10:45Z

If you want to begin review, feel free but it is not finished.

Idea is to complete lxc modules , fix some salt cloud code (multiprocessing) and add a saltcloud lxc provider

kiorky · 2014-02-28T19:11:01Z

/cc @thatch45 @regilero

ghost · 2014-02-28T19:50:07Z

Test FAILed.
Refer to this link for build results: http://jenkins.saltstack.com/job/salt-pr-build/1915/

ghost · 2014-02-28T19:54:10Z

Test FAILed.
Refer to this link for build results: http://jenkins.saltstack.com/job/salt-pr-build/1916/

ghost · 2014-03-01T15:34:39Z

Test FAILed.
Refer to this link for build results: http://jenkins.saltstack.com/job/salt-pr-build/1923/

techhat · 2014-03-01T16:06:57Z

@s0undt3ch, would you please take a close look at this?

s0undt3ch · 2014-03-01T16:24:19Z

@techhat I sure will, though, once I have the necessary time available... @kiorky don't despair!

mgwilliams · 2014-03-01T18:23:27Z

Note that lxc userspace tools v1.0 was released last week. It is a complete overhaul of the tools, and I think packages are going to be aggressively pushed out for current OS releases. While it is mostly backwards compatible, it did break the salt lxc module. I mention it here, as some of the updates for 1.0 (particularly the lxc.info function) would not be incompatible with this pull request. I should have my updates pushed out by end of day on Monday.

kiorky · 2014-03-01T18:43:33Z

what im doing is 1.0 only anyway. :)

kiorky · 2014-03-01T18:44:18Z

And, im thinking im now at 75%/80% done.

kiorky · 2014-03-01T18:44:39Z

(i think i wont have time to add much tests for the moment)

kiorky · 2014-03-01T18:47:57Z

rebased my current working copy, there must be debug and pdb in there ^^

kiorky · 2014-03-01T18:49:42Z

Strangely github doesnt show commits in the order of my git log does

ghost · 2014-03-01T19:22:33Z

Test FAILed.
Refer to this link for build results: http://jenkins.saltstack.com/job/salt-pr-build/1929/

ghost · 2014-03-02T01:44:59Z

Test FAILed.
Refer to this link for build results: http://jenkins.saltstack.com/job/salt-pr-build/1932/

ghost · 2014-03-02T01:52:14Z

Test FAILed.
Refer to this link for build results: http://jenkins.saltstack.com/job/salt-pr-build/1933/

ghost · 2014-03-02T02:47:07Z

Test FAILed.
Refer to this link for build results: http://jenkins.saltstack.com/job/salt-pr-build/1934/

ghost · 2014-03-02T02:48:42Z

Test FAILed.
Refer to this link for build results: http://jenkins.saltstack.com/job/salt-pr-build/1935/

kiorky · 2014-03-02T10:22:37Z

#10884 fixes one of the broken tests

ghost · 2014-03-02T10:42:21Z

Test FAILed.
Refer to this link for build results: http://jenkins.saltstack.com/job/salt-pr-build/1937/

ghost · 2014-03-02T11:09:34Z

Test FAILed.
Refer to this link for build results: http://jenkins.saltstack.com/job/salt-pr-build/1939/

ghost · 2014-03-02T14:37:00Z

Test FAILed.
Refer to this link for build results: http://jenkins.saltstack.com/job/salt-pr-build/1942/

ghost · 2014-03-02T15:05:09Z

Test FAILed.
Refer to this link for build results: http://jenkins.saltstack.com/job/salt-pr-build/1943/

ghost · 2014-03-02T15:12:00Z

Test FAILed.
Refer to this link for build results: http://jenkins.saltstack.com/job/salt-pr-build/1944/

kiorky · 2014-03-02T22:03:16Z

I think that 100% of the stuff is there, im now doing some tests, but review can be done.

Ping @thatch45 @s0undt3ch

ghost · 2014-03-03T10:13:34Z

Test FAILed.
Refer to this link for build results: http://jenkins.saltstack.com/job/salt-pr-build/1952/

s0undt3ch · 2014-03-03T10:19:02Z

Ok. My first observation is, can you submit the LXC stuff on another PR(even if one depends on the other, just mention it)? Does it really neend to be the same?

My other comments will come a little later since inline commenting from the phone is not that great.

kiorky · 2014-03-03T11:38:41Z

Well, it will be tedious for me to locally have them separated as they are very dependant... Or if i inter-merge branches, then the history would be cluterred

kiorky · 2014-03-03T11:54:32Z

So i created #10897 & #10898 which on this PR is dependant, @s0undt3ch

mgwilliams · 2014-03-05T20:38:48Z

salt/states/lxc.py

+    return ret
+
+
+def cloned(name,


Just a thought... would it make more sense to have a single present state that delegates to created and cloned?

the provision which does that is on salt-cloud, @mgwilliams.

it was does in state at a moment, but was removed and rebased for a long time :)

ghost · 2014-03-05T22:37:13Z

Test FAILed.
Refer to this link for build results: http://jenkins.saltstack.com/job/salt-pr-build/2066/

s0undt3ch · 2014-03-06T00:01:12Z

salt/cloud/__init__.py

 import glob
 import time
 import signal
 import logging
+from pprint import pprint


Are you using this pprint import?

uhm, not sure anymore

ghost · 2014-03-06T00:42:44Z

Test FAILed.
Refer to this link for build results: http://jenkins.saltstack.com/job/salt-pr-build/2079/

provider as a special meaning in salt ... http://docs.saltstack.com/ref/states/providers.html

…ecmod

ghost · 2014-03-06T16:26:18Z

Test FAILed.
Refer to this link for build results: http://jenkins.saltstack.com/job/salt-pr-build/2092/

[MUST BE CAREFULLY REVIEWED] saltcloud / lxc improvments

kiorky · 2014-03-06T20:37:30Z

/cc @regilero @jpcw @toutpt @Gagaro @jpoliva it's in!

This was referenced Mar 3, 2014

salt.runner.jobs: optionnal toggle for output #10897

Merged

Lxc #10898

Merged

mgwilliams reviewed Mar 5, 2014
View reviewed changes

s0undt3ch reviewed Mar 6, 2014
View reviewed changes

kiorky added 18 commits March 6, 2014 16:09

salt.cloud: Better multiprocessing handling

08aa9a8

salt.cloud: race because of wrong configuration

4a67dcd

salt.cloud: race: if misconfiguration, boolean instead of dict

0d8661b

salt.cloud: race if item was removed in another loop

94c3c68

salt.cloud.utils: safebelts for provision in sudo mode

7ca9fe5

salt.modules.cloud: virtual return name

01bad30

salt.states.cloud: py3k dict iter

cb2a661

salt.states.cloud.present: fix mis-use of provider

275ef93

provider as a special meaning in salt ... http://docs.saltstack.com/ref/states/providers.html

salt.cloud.states: add onlyif/unless

2f45a99

salt.cloud.states.present: support profile kwargs

918d85d

salt.cloud: allow specific per node profile overrides

9f27fa0

salt.cloud.lxc: lxc provider

972efca

lxc code review

3647ffc

cloud.lxc: style

6914fcb

lxc: do not trigger state change without a change

d226ccf

salt.states.lxc: fix signature in case or argument order change in ex…

f15961c

…ecmod

last lxc review bits

37f8a66

pep8 fixes

d12253b

techhat added a commit that referenced this pull request Mar 6, 2014

Merge pull request #10869 from makinacorpus/cloud_salt

93d7ff2

[MUST BE CAREFULLY REVIEWED] saltcloud / lxc improvments

techhat merged commit 93d7ff2 into saltstack:develop Mar 6, 2014

kiorky deleted the cloud_salt branch March 6, 2014 21:14

[MUST BE CAREFULLY REVIEWED] saltcloud / lxc improvments #10869

[MUST BE CAREFULLY REVIEWED] saltcloud / lxc improvments #10869

Conversation

kiorky commented Feb 28, 2014

kiorky commented Feb 28, 2014

ghost commented Feb 28, 2014

ghost commented Feb 28, 2014

ghost commented Mar 1, 2014

techhat commented Mar 1, 2014

s0undt3ch commented Mar 1, 2014

mgwilliams commented Mar 1, 2014

kiorky commented Mar 1, 2014

kiorky commented Mar 1, 2014

kiorky commented Mar 1, 2014

kiorky commented Mar 1, 2014

kiorky commented Mar 1, 2014

ghost commented Mar 1, 2014

ghost commented Mar 2, 2014

ghost commented Mar 2, 2014

ghost commented Mar 2, 2014

ghost commented Mar 2, 2014

kiorky commented Mar 2, 2014

ghost commented Mar 2, 2014

ghost commented Mar 2, 2014

ghost commented Mar 2, 2014

ghost commented Mar 2, 2014

ghost commented Mar 2, 2014

kiorky commented Mar 2, 2014

ghost commented Mar 3, 2014

s0undt3ch commented Mar 3, 2014

kiorky commented Mar 3, 2014

kiorky commented Mar 3, 2014

mgwilliams Mar 5, 2014

Choose a reason for hiding this comment

kiorky Mar 5, 2014

Choose a reason for hiding this comment

kiorky Mar 5, 2014

Choose a reason for hiding this comment

ghost commented Mar 5, 2014

s0undt3ch Mar 6, 2014

Choose a reason for hiding this comment

kiorky Mar 6, 2014

Choose a reason for hiding this comment

ghost commented Mar 6, 2014

ghost commented Mar 6, 2014

kiorky commented Mar 6, 2014